feat: custom tags and attributes #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11
This was partially done in #25, where they added
details,summary, anddeltags. Unfortunately they forgot theopenattribute fordetails, which I've fixed here. I've additionally added a test covering these tags, mainly to ensure there is no regression when I switch to the unified ecosystem.As for the actual issue, I've sadly never heard of most of the tags requested. Additionally, this seems like a game of whac-a-mole. If some new tag comes out or is supported by github, then we have to react. So I've instead moved this forward with a twist (based on #85): users can now supply their own
allowedTagsandallowedAttributes.If there is enough desire in the community, then specific tags can of course be added to our default list.
@hashrock, I think this is the last one for today 馃槄