New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console.log format ? #44

Closed

hayd opened this issue Jan 25, 2020 · 1 comment

Labels

help wanted question

Contributor

hayd commented Jan 25, 2020 •

edited

In node console.log(XXX) is prefixed with:

2020-01-17T04:36:04.408Z 330af918-dcb6-448d-945a-60e6c9c0a63d INFO XXX

should this be the case in deno-lambda?

Note:

The id is the request id (which is useful to have as you can look up all the log events from a given request)... which were printed via console (not direct to stdout).
The time stamp is superfluous since it's included in the event metadata.
It's INFO when it's console.log which seems strange. Why is that?
Other platforms (python) don't do this.

My opinion is the timestamp is unnecessary and noisy:

`${REQUEST_ID}\tINFO\tXXX`

is better...

The text was updated successfully, but these errors were encountered:

hayd added help wanted question labels

hayd mentioned this issue

Use same version numbering as deno AKA deno-lambda 1.0 #20

Closed

19 tasks

Contributor Author

hayd commented Jan 27, 2020 •

edited

One solution is to have a DENO_CONSOLELOG_PREFIX env variable that defaults to ?? but could be set to ${new Date().toISOString()}\t${requestId}\t${level}\t if you wanted to match node.

Also partial to python's Logger:

[INFO]\t330af918-dcb6-448d-945a-60e6c9c0a63d\t2020-01-17T04:36:04.408Z\nXXX

Gone with:

expanded:

hayd mentioned this issue

Console prefix #47

Merged

hayd closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment