Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console prefix #47

Merged
merged 3 commits into from
Jan 30, 2020
Merged

Console prefix #47

merged 3 commits into from
Jan 30, 2020

Conversation

hayd
Copy link
Contributor

@hayd hayd commented Jan 28, 2020

Towards #44.

Not wedded to the name DENO_CONSOLELOG_PREFIX...

@hayd
Support DENO_CONSOLELOG_PREFIX and test some console.log behaviour
53e1fa5 
I'm not wedded to the name, but think the support is valuable.
For the moment the default will be '' pending any feedback.
@hayd
deno fmt
836bfd9
@hayd
Copy link
Contributor Author

hayd commented Jan 28, 2020

Tempting to call this DENO_PREFIX.

@hayd hayd mentioned this pull request Jan 28, 2020
Closed
@hayd
Copy link
Contributor Author

hayd commented Jan 29, 2020 

  console.log("1\n2")
  console.log(JSON.stringify({ message: "hello 🦕" }, null, 2))

Screen Shot 2020-01-28 at 22 32 02

@hayd
Use DENO_PREFIX as variable name and set default
dbe3a32 
Test invalid DENO_PREFIX defaults to ''
@hayd
Copy link
Contributor Author

hayd commented Jan 30, 2020

Screen Shot 2020-01-29 at 20 40 36

expanded:

Screen Shot 2020-01-29 at 20 40 18

🤷‍♂

@hayd hayd merged commit d98dbe3 into master Jan 30, 2020
@hayd hayd deleted the console-prefix branch January 30, 2020 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hayd