adds sam.yaml for publishing to SAR #17
Conversation
|
haha, ok this is funny but you CAN deploy with CloudFormation using SAM extension https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-resource-application.html |
There was a problem hiding this comment.
Fantastic, thank you!
Do you have the CLI command(s) you used to do the upload / publish?
It might take a week, or two, for me to have time to wire this up. But this is really useful.
It'd also be great to have a SAM example in the examples, so I will check out the repos you created.
(Edit: and I'll link to arc too)
Let me know if you have any other feedback (specifically if you have an example that uses lots of memory or behaves badly in some other way, the hope is that the runtime should always error cleanly - with a nice message - otherwise it's a bug). It may be this...
| Example custom runtime for Deno | ||
|
|
||
| Resources: | ||
| DenoRuntime: |
There was a problem hiding this comment.
Do you think this would make sense to be called simply "Deno" ? or is it important it's suffixed with Runtime?
There was a problem hiding this comment.
doesn't really matter / just a clarity thing / end user probably won't see it
There was a problem hiding this comment.
In serverless it's very fussy about being called DenoLambdaLayer.
| Properties: | ||
| Content: | ||
| S3Bucket: begin-public-east-1 | ||
| S3Key: deno-runtime.zip |
There was a problem hiding this comment.
Is this deno-lambda-layer.zip ?
There was a problem hiding this comment.
It may be the s3 thing is not required (and can use ContentUri): https://serverless.pub/sar-layers/
There was a problem hiding this comment.
Is this deno-lambda-layer.zip ?
yes
It may be the s3 thing is not required (and can use ContentUri): https://serverless.pub/sar-layers/
maybe! seems the docs are pretty thin and maybe in flux; typical aws! =P
There was a problem hiding this comment.
Didn't work without s3! AWS docs seem very thin :)
|
Sorry for the delay, will ship this next week. |
|
I've published to here: https://serverlessrepo.aws.amazon.com/applications/arn:aws:serverlessrepo:us-east-1:390065572566:applications~deno Happy to take feedback @brianleroux ! Does it look correct? ps. how did you get verified by AWS?? |
|
|
|
merged in #27. Thanks! |
|
It's tempting to make lower case |
|
The user experience is SO WEIRD. LOL. I got verified because of the open source work I've done w arc.codes and serverlessness in general. I can def put in a good word for you. Maybe hit me up via email? brian@begin.com and I can relay to the right AWS folk. Haven't taken the release for a spin yet but will do 🔜 ! |
💯 I dropped you an email. I've added and verified the example-sam and example-serverless directories work so hopefully yours will to... 🤞 |
Specifically console.log will always be one cloudwatch log event Fixes #17.
|
I submitted to get verified status and was accepted (it takes a few days to process/go live). https://docs.aws.amazon.com/serverlessrepo/latest/devguide/serverlessrepo-verified-author.html |
Here's the SAM needed to upload to SAR! I just used the console to create it…literally uploading that file manually. (You'll need to change the S3 bucket in the file to point to one that you control (and that is public).
To automate looks like you'll need to write a script (ironically SAR is not supported by CloudFormation yet). But should be fairly straightforward. If you don't beat me to it will look at making into a Github Action. Also LMK when you get it publishing and I'll remove mine from the SAR so we don't have dueling runtimes!