Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO_COLOR=1 does not works for "Did you mean ..." #12118

Closed
lambdalisue opened this issue Sep 17, 2021 · 3 comments 路 Fixed by #13266
Closed

NO_COLOR=1 does not works for "Did you mean ..." #12118

lambdalisue opened this issue Sep 17, 2021 · 3 comments 路 Fixed by #13266
Labels
bug Something isn't working fix available there is a fix available in a third party library that needs to be merged upstream Changes in upstream are required to solve these issues

Comments

@lambdalisue
Copy link

It seems NO_COLOR=1 does not affect coloring on "Did you mean ..." part.

CleanShot 2021-09-17 at 15 52 20

My Deno version is

deno 1.14.0 (release, x86_64-apple-darwin)
v8 9.4.146.15
typescript 4.4.2

Thanks for the project 馃憤
@bartlomieju bartlomieju added the bug Something isn't working label Sep 17, 2021
@leizongmin
Copy link

I think this a bug of the clap crate. I have just submitted an issue on clap-rs/clap#2776

@satyarohith satyarohith added fix available there is a fix available in a third party library that needs to be merged upstream Changes in upstream are required to solve these issues labels Sep 19, 2021
@leizongmin
Copy link

The clap crate has already fixed this problem since 3.0.0-beta.1, we should wait for the clap@3.0.0 release.

@crowlKats
Copy link
Member

Related to #8475 then

@lucacasonato lucacasonato mentioned this issue Jan 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fix available there is a fix available in a third party library that needs to be merged upstream Changes in upstream are required to solve these issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: clap v3 crowlKats/deno
5 participants
@lambdalisue @leizongmin @crowlKats @bartlomieju @satyarohith