Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: tracking issue for running find-up test case #12999

Closed
5 of 6 tasks
kt3k opened this issue Dec 6, 2021 · 8 comments
Closed
5 of 6 tasks

compat: tracking issue for running find-up test case #12999

kt3k opened this issue Dec 6, 2021 · 8 comments

Comments

@kt3k
Copy link
Member

kt3k commented Dec 6, 2021

This issue is part of #12886

This issue tracks the remaining issue for running the test cases of find-up in node-compat mode.

ref #12577

@bartlomieju
Copy link
Member

Getting inspector polyfilled will be a rather involved effort, as we don't have any runtime APIs exposing inspector functionalities. @kt3k could you check which APIs from that module are actually required?

@kt3k
Copy link
Member Author

kt3k commented Dec 7, 2021

inspector is used in ava. ref: https://github.com/avajs/ava/blob/main/lib/cli.js#L119-L121

But if inspector.url() returns undefined, it seems that ava is not going to use the actual inspector features

@bartlomieju
Copy link
Member

@kt3k maybe we could shim it for now and always return undefined?

@kt3k
Copy link
Member Author

kt3k commented Dec 9, 2021

ava@latest seems needing ipc features (process.send(), process.on("message") ) to communicate with forked child_processes in which the actual test cases are running.. 😬

@kt3k
Copy link
Member Author

kt3k commented Dec 9, 2021

IPC BoardcastChannel is not available yet #10750

@kt3k
Copy link
Member Author

kt3k commented Dec 9, 2021

find-up now seems working and I can run nps command in node compat mode without an issue. (I don't know what exactly fixed the issue, but the issue doesn't reproduce now). Closing

@kt3k kt3k closed this as completed Dec 9, 2021
@bartlomieju
Copy link
Member

ava@latest seems needing ipc features (process.send(), process.on("message") ) to communicate with forked child_processes in which the actual test cases are running.. 😬

Seems directly related to #12879

@kt3k
Copy link
Member Author

kt3k commented Dec 9, 2021

Yeah, exactly. Let's track on that issue

I feel IPC features are widely used in npm ecosystem. So I think we need somehow to support it until v0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants