New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ext/timers): create primordial eval
#15110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a test?
This comment was marked as outdated.
This comment was marked as outdated.
@ry May you review this again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: I might go with some other name like primordialEval
but that's just a nit.
@phosra any chance you could update |
I opened an issue about it there about a week ago: denoland/deno_lint#1062. (Nonetheless, must that hold off this bug fix?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @phosra, nice fix
Checks pass, this should be clear to merge. |
Includes
eval
in primordials; this was needed to prevent user modification of timers execution.Alternatively it could've used
Deno.core.evalContext
?