fix(npm): better node version and version requirement compatibility #15714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Aug 31, 2022
| @@ -78,7 +78,8 @@ indexmap = "1.8.1" | |||
| jsonc-parser = { version = "=0.21.0", features = ["serde"] } | |||
| libc = "=0.2.126" | |||
| log = { version = "=0.4.17", features = ["serde"] } | |||
| mitata = '=0.0.7' | |||
| mitata = "=0.0.7" | |||
| monch = "=0.2.0" | |||
There was a problem hiding this comment.
Already a dependency of deno_task_shell.
bartlomieju
approved these changes
Sep 1, 2022
| assert!(!tester.matches("0.1.0")); | ||
| assert!(!tester.matches("1.0.0")); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially used the
semvercrate as a first pass solution, but this PR adds way better node semver support.Wrote an in-house solution so we can move fast fixing bugs and re-use some of the code for our npm specifiers. The npm specifiers use a stricter parser than the version requirements allowed in package.json files.
Closes #15600