Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Fix panic when providing invalid urls to --reload #15784

Merged
merged 2 commits into from Sep 6, 2022
Merged

fix(cli): Fix panic when providing invalid urls to --reload #15784

merged 2 commits into from Sep 6, 2022

Conversation

sagea
Copy link
Contributor

@sagea sagea commented Sep 6, 2022

Description

Modifies the --reload flag to handle invalid URLs gracefully instead of panicking.

#15770

Before:
image

After:

image

image

PR Requirements

  1. Issue for ticket: ✅ [Bug 1.25.1] (Deno has panicked) - Bad url provided to the deno test --reload flag #15770
  2. Tests are written: ✅
  3. Tests pass: ✅
  4. Formatting Passes: ✅
  5. Linting Passes: ✅

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@sagea sagea force-pushed the fix-cli-reload-flag-bad-url branch from 65c41f2 to 15a9240 Compare September 6, 2022 03:34
@bartlomieju bartlomieju changed the title Fix(cli): Fix panic when providing invalid urls to --reload fix(cli): Fix panic when providing invalid urls to --reload Sep 6, 2022
bartlomieju
bartlomieju approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix @sagea!

@bartlomieju bartlomieju merged commit c0a684c into denoland:main Sep 6, 2022
kt3k pushed a commit that referenced this pull request Sep 9, 2022
@sagea @kt3k
fix(cli): Fix panic when providing invalid urls to --reload (#15784)
83dcf6e
@lino-levan lino-levan mentioned this pull request Sep 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sagea @CLAassistant @bartlomieju