Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): use shim from deno_node crate for 'module' built-in module #15881

Merged
merged 2 commits into from Sep 12, 2022
Merged

fix(npm): use shim from deno_node crate for 'module' built-in module #15881

merged 2 commits into from Sep 12, 2022

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 12, 2022 •
edited

Closes #15880

Merge on approval

dsherret
dsherret approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 233d542 into denoland:main Sep 12, 2022
cjihrig pushed a commit that referenced this pull request Sep 15, 2022
@bartlomieju @cjihrig
fix(npm): use shim from deno_node crate for 'module' built-in module (#…
89ef56a 
…15881)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error running vite using Deno
2 participants
@bartlomieju @dsherret