Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Stabilize Deno.hostname() API #15932

Merged
merged 3 commits into from Sep 28, 2022
Merged

feat: Stabilize Deno.hostname() API #15932

merged 3 commits into from Sep 28, 2022

Conversation

bartlomieju
Copy link
Member

Closes #15927

@bartlomieju bartlomieju added this to the 1.26 milestone Sep 17, 2022
cmoog
cmoog reviewed Sep 17, 2022
View reviewed changes
runtime/ops/os.rs Outdated Show resolved Hide resolved
@kt3k kt3k mentioned this pull request Sep 22, 2022
Closed
@bartlomieju
Copy link
Member Author

I will merge this PR after #16028 is merged.

dsherret
dsherret approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit b8e3f4c into denoland:main Sep 28, 2022
@bartlomieju bartlomieju deleted the stabilize_deno_hostname branch September 28, 2022 13:36
@sant123 sant123 mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k left review comments

@cmoog cmoog cmoog left review comments

@dsherret dsherret dsherret approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

@piscisaureus piscisaureus Awaiting requested review from piscisaureus

@ry ry Awaiting requested review from ry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.

Stabilize Deno.hostname()
5 participants
@bartlomieju @kt3k @dsherret @cmoog @lucacasonato