feat: add --allow-sys permission flag #16028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
force-pushed
the
allow-sys-info
branch
2 times, most recently
from
a69bf27
to
110e915
Compare
kt3k
force-pushed
the
allow-sys-info
branch
from
110e915
to
21df843
Compare
|
cc @nayeemrmn |
bartlomieju
reviewed
Sep 27, 2022
cli/args/flags.rs
Outdated
| .takes_value(true) | ||
| .use_value_delimiter(true) | ||
| .require_equals(true) | ||
| .help("Allow access to system info"), |
There was a problem hiding this comment.
Right now this flag can accept arbitrary values, I suggest to add a validator here that will limit options
There was a problem hiding this comment.
added validation of sys kind in 3 places:
allow-sysarg values are validatedkindprop ofSysPermissionDescriptoris now typed as"hostname" | "loadavg" | ...(in TypeScript)op_{query|revoke|request}_permissionthrows TypeError when the kind is invalid
kt3k
changed the title
bartlomieju
approved these changes
Sep 28, 2022
Comment on lines
+1837
to
+1843
| match key { | ||
| "hostname" | "osRelease" | "loadavg" | "networkInterfaces" | ||
| | "systemMemoryInfo" | "getUid" | "getGid" => {} | ||
| _ => { | ||
| return Err(format!("unknown system info kind \"{}\"", key)); | ||
| } | ||
| } |
There was a problem hiding this comment.
This could be de-duplicated with parse_sys_kind, I think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
--allow-syspermission flag to control the access to the system infromations such asloadavg,hostname,networkInterfaces,getUid,getGid,osRelease, andsystemMemoryInfo.Summary of changes
Rust
SysDescriptor(pub String)typeUnaryPermission<SysDescriptor>PermissionsstructdeserializerforChildPermissionsArgcreate_child_permissionsfunction--allow-sysflag handlingJS
TS
SysPermissionDescriptortypePermissionOptionsObjectto acceptsyspermDoc
@tagsfor 7 methods.closes #15986