Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(napi): move napi symbols file #16179

Merged
merged 2 commits into from Oct 7, 2022
Merged

fix(napi): move napi symbols file #16179

merged 2 commits into from Oct 7, 2022

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 6, 2022

The current location was causing failures during v1.26.1 publication.

The current location was causing failures during
v1.26.1 publication.
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit c272348 into denoland:main Oct 7, 2022
@cjihrig cjihrig deleted the napi branch October 7, 2022 22:23
bartlomieju pushed a commit that referenced this pull request Oct 17, 2022
The current location was causing failures during v1.26.1 publication.

<!--
Before submitting a PR, please read http://deno.land/manual/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants