Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): properly handle snippets on completions #16274

Merged
merged 1 commit into from Oct 14, 2022
Merged

fix(lsp): properly handle snippets on completions #16274

merged 1 commit into from Oct 14, 2022

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Oct 14, 2022 •
edited

Fixes #15367

Properly handles detecting if clients support snippet text and sets the snippet text type on completion items where appropriate.

lucacasonato
lucacasonato approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested it locally, and it is working! 🎉

@kitsonk kitsonk merged commit afcea6c into denoland:main Oct 14, 2022
@kitsonk kitsonk deleted the fix_snippets branch October 14, 2022 12:04
bartlomieju pushed a commit that referenced this pull request Oct 17, 2022
@kitsonk @bartlomieju
fix(lsp): properly handle snippets on completions (#16274)
7fa41d9 
Fixes #15367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp: completions in jsx props, the value is set to "$1" or {$1}
2 participants
@kitsonk @lucacasonato