[Debug Mode] Debugger doesn't terminate when code finishes or error **IF** a NPM package is inside deno.lock

[pietro-lopes]

Title, and related to #16628

CODE RUNS FINE WITHOUT DEBUGGING

Tested on

deno 1.28.0 (release, x86_64-unknown-linux-gnu)
v8 10.9.194.1
typescript 4.8.3

OS: Pop 22.04 jammy
Kernel: x86_64 Linux 6.0.3-76060003-generic

With VSCode & Chrome Debugger

In this example code you can attach/launch a debugger with no problem when finishing program
Lock file will contain only remote imports

import { crypto } from "https://deno.land/std@0.164.0/crypto/mod.ts"
import { encodeToString } from "https://deno.land/std@0.85.0/encoding/hex.ts";
// import { keccak_256 } from "npm:@noble/hashes@1.1.2/sha3"

console.log(crypto.randomUUID())
// console.log(encodeToString(keccak_256("testing")))

Here you will add the NPM package noble/hashes to your lock file to run and debugger will not close when finishing
Lock file will contain remote & npm imports

import { crypto } from "https://deno.land/std@0.164.0/crypto/mod.ts"
import { encodeToString } from "https://deno.land/std@0.85.0/encoding/hex.ts";
import { keccak_256 } from "npm:@noble/hashes@1.1.2/sha3"

console.log(crypto.randomUUID())
console.log(encodeToString(keccak_256("testing")))

Here you can comment back the NPM package BUT it will still not close debugger.
Lock file will contain remote & npm imports

import { crypto } from "https://deno.land/std@0.164.0/crypto/mod.ts"
import { encodeToString } from "https://deno.land/std@0.85.0/encoding/hex.ts";
// import { keccak_256 } from "npm:@noble/hashes@1.1.2/sha3"

console.log(crypto.randomUUID())
// console.log(encodeToString(keccak_256("testing")))

Only way to fix it is by removing NPM packages from deno.lock or delete so it can generates back with only remotes.

[bartlomieju]

Hi @pietro-lopes I just tried this code and cannot reproduce the problem. What do you mean by "debugger will not close when finishing"? As it is, the debugger never disconnects automatically if it is connected - you have to do so manually by closing the inspector window. Can you please provide the commands you used to get this problem?

[pietro-lopes]

As it is, the debugger never disconnects automatically if it is connected - you have to do so manually by closing the inspector window

If I have to close manually, how will I know that code really finished or is hanging on some exception like this:
#16628 (comment)

Command used are in launch.json from .vscode:

      "runtimeExecutable": "/home/myusername/.deno/bin/deno",
      "runtimeArgs": [
        "run",
        "--config",
        "./deno.jsonc",
        "--inspect-brk",
        "--allow-all"
      ],
      "attachSimplePort": 9229

[bartlomieju]

I missed that you are using VSCode debugger, I was talking about the Chrome DevTools debugger. I'll look into this problem.

[bartlomieju]

@pietro-lopes just to be completely sure - the problem that you are reporting is that after running the code, "the box" with play/step over/pause/stop buttons is not disappearing. Is that correct?

[bartlomieju]

Requires denoland/rusty_v8#1134

[bartlomieju]

This issue will be fixed by #16831 and #16836

[bartlomieju]

Done, this will be released in v1.28.3