Runtime raising TypeError instead of Deno.errors.NotFound

[jflatow]

When using the deno runtime crate (as recent as 0.86) I am definitely getting not found exceptions ("TypeError: No such file or directory (os error 2)") of a different error type than expected, which is causing things like fs.exists to fail. Working on a minimal reproduction, but figured worth filing this issue already as I'm 99% sure its a bug in the runtime, and may be helpful for others.

[lucacasonato]

Make sure your errors are registered like this: https://github.com/denoland/deno/blob/main/runtime/js/99_main.js#L255 and you provide deno_core::JsRuntime with the correct get_error_class_name implementation (e.g https://github.com/denoland/deno/blob/main/runtime/errors.rs#L155)

Please re-open if this does not fix your issue.

[jflatow]

Make sure your errors are registered like this: https://github.com/denoland/deno/blob/main/runtime/js/99_main.js#L255

Is there an example which explicitly loads these runtime modules?

[bartlomieju]

Make sure your errors are registered like this: https://github.com/denoland/deno/blob/main/runtime/js/99_main.js#L255

Is there an example which explicitly loads these runtime modules?

Which modules are you asking about?

[jflatow]

Make sure your errors are registered like this: https://github.com/denoland/deno/blob/main/runtime/js/99_main.js#L255

Is there an example which explicitly loads these runtime modules?

Which modules are you asking about?

All the modules in that directory (https://github.com/denoland/deno/tree/main/runtime/js), I naively would have thought they all got loaded somehow, but seems like that may not be the case given the situation with the errors. Although I think they still must be, or I wouldn't be able to use any of the things I am already using in the runtime.

If they are indeed being loaded, then I should re-open this issue, since adding the get_error_class_fn does not solve.

[CheatCod]

Were you able to figure out how to register the errors and get_error_class_name?

[jflatow]

No, not reliably, I (unfortunately) ended up working around by matching error messages instead of trying to work with the error types