lsp doesn't respect deno.unstable

[sigmaSd]

This seems to be a recent regression, I don't get unstable types anymore

Deno.dlopen // type error here

settings.json

{
    "deno.enable": true,
    "deno.lint": true,
    "deno.unstable": true,
}

deno 1.38.0

[irbull]

I pulled down the latest VSCode Extension and self hosted from source (commit denoland/vscode_deno@5c13d5f) and it's not happening here. It's happening 3.26.0 too, so maybe it was fixed recently. I can't see a commit that explicitly calls this out though.

[irbull]

Sorry, I take that back. I can reproduce this with the latest from main as well. Seems that it happens as soon as you initialize the Deno Workspace. However, if you change the unstable setting to false and then change it back to true it works. Could be something in how the notification for the settings is propagated.

[bartlomieju]

CC @nayeemrmn please take a look

[irbull]

Small update, this appears to only happen if the VSCode plugin is not yet activated, and the act of initializing the workspace activates the plugin. By the time last call to: extensionContext.client?.sendNotification("workspace/didChangeConfiguration",...); is made, the settings have the correct values, so it appears the VS Code Extension is setting and propagating things correctly. There may be an timing issue between the plugin and the LSP Server on startup or maybe an cached setting in the LSP that's not being cleared.

I'd be happy to look into this further as I'm curious about the LSP Protocol; although I don't want to step on anyones toes. I'd have to try and self host an LSP Server too.

[nayeemrmn]

@sigmaSd

1. Are you on vscode?
2. Do you have any files in your project which have /// <reference no-default-lib="true" />?

[sigmaSd]

I had this issue in helix but I tried with vscode just to confirm, the issue is this

Do you have any files in your project which have /// <reference no-default-lib="true" />?

Yes turns out that's the issue, its a bit surprising, since the file that have that is in a nested folder inside the project and I didn't even open it, but I guess its because of the lsp preload

[nayeemrmn]

@sigmaSd In that case you need to add /// <reference lib="deno.unstable" /> below that directive. We're working on better ways of partitioning type spaces in a project.

@irbull Is this also what's happening in your case? If not, please open a new issue thanks.

[dsherret]

Note that #20420 might prevent no-default-lib from removing the types for the Deno global in the future

[sgwilym]

I'm having this problem even without the presence of no-default-lib in the Nova IDE. The unstable option is correctly set to true when the LSP is initialised.

[sgwilym]

It does start working once a workspace/didChangeConfiguration message with deno.unstable set is received though.

Maybe setting it only through initialisation options doesn't work? Maybe the absence of this option in future config messages turns it off?