Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node:http(s): null value is not allowed for header value #21389

Closed
kt3k opened this issue Nov 30, 2023 · 1 comment · Fixed by #21391
Closed

node:http(s): null value is not allowed for header value #21389

kt3k opened this issue Nov 30, 2023 · 1 comment · Fixed by #21391

Comments

@kt3k
Copy link
Member

kt3k commented Nov 30, 2023

null value is allowed for request.setHeader value in Node.js, but it doesn't in Deno

import http from "node:http";
const req = http.request("http://localhost:8000")
req.setHeader("x-foo", null)

The above sends the header Headers { connection: "close", host: "0.0.0.0:8000", "x-foo": "null" } in Node.js

@kt3k
Copy link
Member Author

kt3k commented Nov 30, 2023

This incompatibility caused an issue in twisted Sansossio/twisted#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants