Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use globalThis instead #2195

Closed
motss opened this issue Apr 24, 2019 · 3 comments
Closed

Use globalThis instead #2195

motss opened this issue Apr 24, 2019 · 3 comments

Comments

@motss
Copy link
Contributor

motss commented Apr 24, 2019

Is this a good time to refactor this to use globalThis which has been supported since v8 v7.1?

deno/js/window.ts

Line 7 in d68b44b

export const window = (0, eval)("this");

@kitsonk
Copy link
Contributor

kitsonk commented Apr 26, 2019

There were some issues in earlier versions of v8 when snapshotting where globalThis wasn't available... I never was able to isolate it, but that is what prevented the refactor before (I tried it). That may have been addressed now. Worth trying again.

@motss
Copy link
Contributor Author

motss commented Apr 26, 2019

@kitsonk I'll take it and see what happens.

@motss
Copy link
Contributor Author

motss commented Apr 27, 2019

Closing this for now as the same issues happen.

@motss motss closed this as completed Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kitsonk @motss