Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sloppy import resolution is flaky in the lsp #23197

Closed
dsherret opened this issue Apr 3, 2024 · 0 comments · Fixed by #23751
Closed

Sloppy import resolution is flaky in the lsp #23197

dsherret opened this issue Apr 3, 2024 · 0 comments · Fixed by #23751
Assignees
@nathanwhit
Labels
bug Something isn't working lsp related to the language server node compat

Comments

@dsherret
Copy link
Member

dsherret commented Apr 3, 2024 •
edited

In a project with a deno.json with "unstable": ["sloppy-imports"], using imports like ./AppContext.js resolving to ./AppContext.ts, I found that the resolved specifiers sometimes go to the .js file instead.

For example, in this video it was working, then I restarted the lsp and suddenly it's going to the .js file (actually, before I went to the specifiers file the first time it wasn't working before either).

2024-04-02_21-21-52_flaky.mp4

Reproduction steps:

  1. Check out this PR: chore: migrate to esm and use Deno for development dsherret/ts-ast-viewer#143
  2. npm install
  3. Open the LSP

Version: Deno 1.42.1+57572da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanwhit nathanwhit

Labels
bug Something isn't working lsp related to the language server node compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lsp): move sloppy import resolution from loader to resolver nathanwhit/deno
2 participants
@dsherret @nathanwhit