Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FUTURE: deno install should not download/copy packages if node_modules/ dir is up to date #23907

Open
bartlomieju opened this issue May 20, 2024 · 1 comment
Open

FUTURE: deno install should not download/copy packages if node_modules/ dir is up to date #23907

bartlomieju opened this issue May 20, 2024 · 1 comment
Assignees
@nathanwhit
Labels
feat new feature (which has been agreed to/accepted) node compat
Milestone
2.0

Comments

@bartlomieju
Copy link
Member

Currently with DENO_FUTURE=1 running deno install on a repo that has a package.json will first download and cache all needed packages, then set up node_modules/. On subsequent runs the packages are already cached but the set up of node_modules/ directory happens from scratch even though it's already in sync.

We should optimize this scenario by checking the state of node_modules/ directory and only setting up (or removing) dependencies that have changed.
@bartlomieju bartlomieju added this to the 2.0 milestone May 20, 2024
@bartlomieju bartlomieju mentioned this issue May 20, 2024
Open
@bartlomieju
Copy link
Member Author

Ref #23062

@bartlomieju bartlomieju changed the title FUTURE: deno install should download/copy packages if node_modules/ dir is up to date FUTURE: deno install should not download/copy packages if node_modules/ dir is up to date May 21, 2024
@lucacasonato lucacasonato added the feat new feature (which has been agreed to/accepted) label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanwhit nathanwhit

Labels
feat new feature (which has been agreed to/accepted) node compat
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@lucacasonato @bartlomieju @nathanwhit