Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deno lockfile in projects with only package.json #23571

Closed
nathanwhit opened this issue Apr 26, 2024 · 0 comments · Fixed by #23918
Closed

Support deno lockfile in projects with only package.json #23571

nathanwhit opened this issue Apr 26, 2024 · 0 comments · Fixed by #23918

Comments

@nathanwhit
Copy link
Member

Currently we only use deno.lock files if you have a deno.json.

nathanwhit added a commit that referenced this issue May 23, 2024
…_FUTURE install interactions with lockfile (#23918)

Fixes #23571.

Previously, we required a `deno.json` to be present (or the `--lock`
flag) in order for us to resolve a `deno.lock` file. This meant that if
you were using deno in an npm-first project deno wouldn't use a
lockfile.

Additionally, while I was fixing that, I discovered there were a couple
bugs keeping the future `install` command from using a lockfile.

With this PR, `install` will actually resolve the lockfile (or create
one if not present), and update it if it's not up-to-date. This also
speeds up `deno install`, as we can use the lockfile to skip work during
npm resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants