Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using JSR package in Vite running in Deno #23929

Open
etienne-dldc opened this issue May 21, 2024 · 1 comment
Open

Using JSR package in Vite running in Deno #23929

etienne-dldc opened this issue May 21, 2024 · 1 comment

Comments

@etienne-dldc
Copy link

etienne-dldc commented May 21, 2024

Hi,

I'm really excited about JSR and I started migrating the few packages I maintain (mostly for myself given their popularity 😅) from Node + NPM to Deno + JSR:

It worked quite well so far but I ran into a issue: In some of my project I had a folder with a Vite project to showcase an example of the package.

I managed to get Vite running in Deno and using --node-modules-dir and I can import npm packages fine but not JSR packages.

I see 2 potential solution to this:

1. Vite plugin

Option 1 would be to have a Vite plugin for Deno that would implement the same module resolution.
There is already some existing but I did not found any that supports jsr.

On that note, are there any plan to expose the module resolver from Deno to make it easier to create such tool ?

The downside of this solution is that it would be a Vite only solution and won't work for other bundlers.

2. Expose JSR packages in node_modules

Another option would be to make Deno also expose JSR packages in node_modules when running --node-modules-dir, this way the classic Node module resolution would also work.

@etienne-dldc
Copy link
Author

Side note: since I could not make it work with Vite I used esbuild and @luca/esbuild-deno-loader in the meantime, you can see it in this repo: dldc-packages/canvas.
But I would much prefer to be able to use Vite as it's a more common setup and requires less tinkering than Esbuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant