Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle signal 0 on windows as well on process.kill #23938

Open
sigmaSd opened this issue May 22, 2024 · 1 comment
Open

handle signal 0 on windows as well on process.kill #23938

sigmaSd opened this issue May 22, 2024 · 1 comment
Labels
feat new feature (which has been agreed to/accepted) runtime Relates to code in the runtime crate windows Related to Windows platform

Comments

@sigmaSd
Copy link
Contributor

sigmaSd commented May 22, 2024

linux fixed in #23473

I thought in windows we should just ignore the signal, but I checked now libuv and they do special case this

https://github.com/libuv/libuv/blob/d9d207774ea1f734310982300e55dd64b3f5682b/src/win/process.c#L1191

Side note: is it a deliberate choice that process.kill now requires --allow-run permission ? isn't too much ? @littledivy

@sigmaSd sigmaSd changed the title handle signal on windows as well on process.kill handle signal 0 on windows as well on process.kill May 22, 2024
@littledivy
Copy link
Member

is it a deliberate choice that process.kill now requires --allow-run permission

This has always been the case as far as I can see in git blame.

--allow-run is currently the most appropriate permission flag for it since its related to controlling processes. It is a little out of place and could be its own --allow-kill (maybe --allow-unrun 😅)

@lucacasonato lucacasonato added feat new feature (which has been agreed to/accepted) windows Related to Windows platform runtime Relates to code in the runtime crate labels Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat new feature (which has been agreed to/accepted) runtime Relates to code in the runtime crate windows Related to Windows platform
Projects
None yet
Development

No branches or pull requests

3 participants