-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue running v1.0.0 with std@0.50.0 #5319
Comments
This is probably a bug in denon; denosaurs/denon#34 |
I get the same error in my own small test app when I import std@0.50.0/fs using v1.0.0, and not when using v.1.0.0-rc3. deps.ts
main.ts
|
Typescript issue #30821 is commented in the std source so this is probably not an issue with deno nor denon |
Could it be the @ts-ignore is on the wrong line? The issue linked in the https://deno.land/std@v0.50.0/fs/_util.ts source talks about inference showing a false positive (I think). Putting a @ts-ignore and a comment explaining why is the A+ way to deal with it in my book. Yet, an error shows up and blocks the install of Denon and I'm guessing any other package importing this module. Error shows up on line 20, ts-ignore is on line 21. |
Went to fix it but noticed it's already fixed in master (3d7552a) 🎉 . You people move fast! Thanks @kitsonk 🙏 . |
Doesn't work for me with
...results in:
Version (on Windows 10):
|
@C0Nd3Mnd use |
I tried Deno today. Congrats on 1.0.0, I wanted to report an issue I ran into at risk of embarrassing myself, it's possible that I just don't know what I'm doing.
I started today with v1.0.0-rc3 and used a few dependencies (fs, path, http) and denon as an installed cli tool. It worked fine.
When v1.0.0 was released I tried running my test application again and ran into a TS error.
I was able to resolve this one of two ways for my project.
With some investigating it seems like maybe this changed caused a desync between the runtime and std. 3d7552a#diff-da37be1ae0975896a3e9d32a5131aeae
In order to get denon working my only option is to downgrade deno to v1.0.0-rc3.
Figure this is fixed with the next release of std, as soon as denon upgrades.
The text was updated successfully, but these errors were encountered: