Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: importing from .d.ts files causes panic #7069

Closed
lucacasonato opened this issue Aug 16, 2020 · 2 comments
Closed

regression: importing from .d.ts files causes panic #7069

lucacasonato opened this issue Aug 16, 2020 · 2 comments
Assignees
Labels
bug Something isn't working correctly cli related to cli/ dir

Comments

@lucacasonato
Copy link
Member

$ deno info --no-check https://deno.land/x/garn_validator@v1.2.24/src/index.d.ts
Warning Failed to get compiled source code of "https://deno.land/x/garn_validator@v1.2.24/src/index.d.ts".
Reason: No such file or directory (os error 2)
If the source file provides only type exports, prefer to use "import type" or "export type" syntax instead.
Warning Failed to get compiled source code of "https://deno.land/x/garn_validator@v1.2.24/src/index.d.ts".
Reason: No such file or directory (os error 2)
If the source file provides only type exports, prefer to use "import type" or "export type" syntax instead.
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ErrBox(Os { code: 2, kind: NotFound, message: "No such file or directory" })', cli/main.rs:234:32
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This broke between 1.2.0 and 1.2.1. It happens with and without --no-check. We are meant to be emitting an empty file, but it doesn't seem to be working anymore. Ref #6760

cc @bartlomieju

@lucacasonato lucacasonato added bug Something isn't working correctly cli related to cli/ dir labels Aug 16, 2020
@bartlomieju bartlomieju self-assigned this Aug 16, 2020
@kitsonk
Copy link
Contributor

kitsonk commented Aug 17, 2020

Roots are handled differently than depended upon modules. #6760 only "fixed" when the ts compiler ops out for a dependency.

@bartlomieju
Copy link
Member

Closed in #6786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly cli related to cli/ dir
Projects
None yet
Development

No branches or pull requests

3 participants