Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno Lint fails with thread 'tokio-runtime-worker' has overflowed its stack #7279

Closed
khrome83 opened this issue Aug 30, 2020 · 4 comments
Closed
Labels
bug Something isn't working correctly cli related to cli/ dir

Comments

@khrome83
Copy link

Since upgrading to Deno 1.3.2 I have seen an overflow error running deno lint --unstable

thread 'tokio-runtime-worker' has overflowed its stack
fatal runtime error: stack overflow
/home/runner/work/_temp/998ca1c5-1210-471d-bd26-b595fc5f0f07.sh: line 1:  4053 Aborted                 (core dumped) deno lint --unstable
##[error]Process completed with exit code 134.

You can see the error here -
https://github.com/use-seedling/seedling/runs/1048772375?check_suite_focus=true

To reproduce, download master of https://github.com/use-seedling/seedling/
Run deno upgrade --version 1.3.2
Run deno lint --unstable

You can see the issue. No error file is output, so I have nothing else to give to show the issue.
The repository did have a lot of warnings for ban-types. I have either fixed or added //deno-lint-ignore ban-types.

@bartlomieju bartlomieju added bug Something isn't working correctly cli related to cli/ dir labels Aug 31, 2020
@bartlomieju
Copy link
Member

bartlomieju commented Aug 31, 2020

Thanks for the report @khrome83 I verified that it's indeed the case even after #7276. Could you try to isolate which file causes the overflow?

Actually it might be related to #7274

EDIT: I found that src/css/prose.ts causes the overflow. CC @kdy1 would you mind taking a look?

@khrome83
Copy link
Author

I have src/css/form.ts which is very similar as well. I believe it's because of the ban-types. I used a // deno-lint-ignore.

@bartlomieju
Copy link
Member

@khrome83 it's not problem with directive, I think somethings wrong in the parser.

@bartlomieju
Copy link
Member

Fixed in #7402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly cli related to cli/ dir
Projects
None yet
Development

No branches or pull requests

2 participants