Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the test coverage blackbox less magical #7563

Closed
caspervonb opened this issue Sep 18, 2020 · 1 comment
Closed

Make the test coverage blackbox less magical #7563

caspervonb opened this issue Sep 18, 2020 · 1 comment
Labels

Comments

@caspervonb
Copy link
Contributor

caspervonb commented Sep 18, 2020

Currently the coverage blackbox is a bit magical in that it checks if an executed script is next to any of the test modules that ran; if it is then it is included in the report.

This works out pretty well for std like modules where the test module is next to the module, but if you want to coverage for something that is elsewhere there is no way to do that.

This issue came up quite a bit on discord where people are using folders for tests.

So, a much, much simpler approach to this is just to make the coverage option an Option<String> which defaults to cwd and test if a module url starts with that value.

Test modules would still be excluded.

WDYT?

@stale
Copy link

stale bot commented Jan 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 6, 2021
@stale stale bot closed this as completed Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant