Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tools/pre-commit.py to lint git commit messages #8236

Closed
getspooky opened this issue Nov 3, 2020 · 4 comments
Closed

Adding tools/pre-commit.py to lint git commit messages #8236

getspooky opened this issue Nov 3, 2020 · 4 comments
Labels
build build system or continuous integration related suggestion suggestions for new features (yet to be agreed)

Comments

@getspooky
Copy link
Contributor

I thinks is good idea to implement a pre-commit script that supports macOS, Linux and Windows.

@kitsonk kitsonk added build build system or continuous integration related suggestion suggestions for new features (yet to be agreed) labels Nov 3, 2020
@kitsonk
Copy link
Contributor

kitsonk commented Nov 3, 2020

I think it is unnecessary... We squash merge commits anyways and clean up the commit messages there. All it would do is make more friction for contributions, which I think would make everyone 😢 .

@bartlomieju
Copy link
Member

I agree with @kitsonk, each PR is merged manually and often commit titles are adjusted before merging. I see no point in enforcing commit message style for commits in the PR which is essentially work-in-progress branch.

@wperron
Copy link
Contributor

wperron commented Nov 4, 2020

I've had this conversation with multiple colleagues and teams in the past, and local git hooks usually don't stand the test of time because there's no way to enforce it; contributors are free to run the init script or not. Bottom line I don't think it would really help maintainers because they'd still have to deal with non-compliant messages.

The current approach of squashing is a better idea in my opinion.

@kitsonk
Copy link
Contributor

kitsonk commented Nov 5, 2020

Enough feedback, thanks everyone.

@kitsonk kitsonk closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build system or continuous integration related suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

No branches or pull requests

4 participants