Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable JSX Namespace by default #154

Closed
jollytoad opened this issue Sep 1, 2023 · 0 comments · Fixed by #155
Closed

Enable JSX Namespace by default #154

jollytoad opened this issue Sep 1, 2023 · 0 comments · Fixed by #155

Comments

@jollytoad
Copy link
Contributor

I'm raising this here, as I've just discovered that this repo is where this issue could be fixed: denoland/deno#20345

deno_ast/src/transpiling/mod.rs

Line 338 in 2910cf3

throw_if_namespace: None,

I believe throw_if_namespace could just be set to Some(false) to solve this?

Unless you want to provide it as an option, but I don't think that's necessary. TypeScript doesn't make this restriction, so I don't know why swc should.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable jsx namespace support by default (#154) jollytoad/deno_ast
1 participant
@jollytoad