Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment variable OUT_DIR for the location of bindings.json #72

Closed
vectronic opened this issue May 10, 2022 · 0 comments · Fixed by #82
Closed

Use environment variable OUT_DIR for the location of bindings.json #72

vectronic opened this issue May 10, 2022 · 0 comments · Fixed by #82
Labels
bug Something isn't working

Comments

@vectronic
Copy link
Contributor

I have a docs.rs build issue when the deno_bindgen attribute is encountered:

https://docs.rs/crate/flowscripter_template_deno_rust_library/1.0.6/builds/556217

From what I can tell this is because deno_bindgen is writing (always) the bindings.json file to the root of the project and this will fail on docs.rs because of readonly permissions:

https://docs.rs/about/builds#read-only-directories

The proposed fix for this is to write build output files into the cargo output directory defined in the environment variable OUT_DIR.

vectronic added a commit to flowscripter/template-deno-rust-library that referenced this issue May 10, 2022
vectronic added a commit to flowscripter/template-deno-rust-library that referenced this issue May 10, 2022
@littledivy littledivy added the bug Something isn't working label May 18, 2022
vectronic added a commit to flowscripter/template-deno-rust-library that referenced this issue May 25, 2022
vectronic added a commit to flowscripter/template-deno-rust-library that referenced this issue May 25, 2022
@vectronic vectronic changed the title Use environment variable OUT_DIR for the location of bindings.js Use environment variable OUT_DIR for the location of bindings.json Jul 12, 2022
vectronic added a commit to vectronic/deno_bindgen that referenced this issue Jul 12, 2022
littledivy pushed a commit that referenced this issue Jul 17, 2022
vectronic added a commit to vectronic/deno_bindgen that referenced this issue Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants