Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update init script for 0.7.0 release #120

Merged
merged 6 commits into from
Jul 6, 2023
Merged

chore: update init script for 0.7.0 release #120

merged 6 commits into from
Jul 6, 2023

Conversation

lino-levan
Copy link
Contributor

Meant to be merged along with #118

@lino-levan lino-levan changed the title chore: update init script for 0.6.0 chore: update init script for 0.6.0 release Mar 11, 2023
@lino-levan
Copy link
Contributor Author

@hashrock PTAL!

@lino-levan lino-levan mentioned this pull request Mar 11, 2023
Closed
hashrock
hashrock reviewed Mar 12, 2023
View reviewed changes
init.ts Show resolved Hide resolved
hashrock
hashrock approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@hashrock hashrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note(probably for me):

  • Do not merge this immediately. You will need to merge the associated PRs and publish 0.6.0.

@hashrock hashrock mentioned this pull request Mar 21, 2023
Closed
4 tasks
@lino-levan
Copy link
Contributor Author

hold on, going to update this commit to bump deps

@lino-levan lino-levan changed the title chore: update init script for 0.6.0 release chore: update init script for 0.7.0 release Jul 6, 2023
@lino-levan
Copy link
Contributor Author

Should be good now. Would be nice to merge #106 along with this.

@lino-levan
Copy link
Contributor Author

lino-levan commented Jul 6, 2023 •
edited
Loading

Hold on, maybe we want to merge the imports into the deno.jsonc? I'll change this PR to do that.

Nevermind, I already did that 😅. This should be good now.

@lino-levan
Copy link
Contributor Author

lino-levan commented Jul 6, 2023 •
edited
Loading

Let me investigate the test failure, probably just due to a flaky test.
Looks like it was just a flaky test.

hashrock
hashrock approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@hashrock hashrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hashrock hashrock merged commit 9115589 into denoland:main Jul 6, 2023
1 check passed
@lino-levan lino-levan deleted the chore-release-0-6-0 branch July 6, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashrock hashrock hashrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lino-levan @hashrock