Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unstable field #14

Merged
merged 4 commits into from
Oct 5, 2023
Merged

feat: add unstable field #14

merged 4 commits into from
Oct 5, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Oct 4, 2023

We'd like to read feature flag from deno.json(c). This PR adds reading of features unstable field.

Related: denoland/deno#20779

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as "Request changes" cause we need a bit of bike-shedding on the name. Otherwise LGTM

@kt3k kt3k requested a review from ry October 4, 2023 12:03
src/lib.rs Outdated
@@ -454,6 +454,8 @@ pub struct ConfigFileJson {
pub workspace: bool,
#[serde(default)]
pub members: Vec<String>,
#[serde(default)]
pub features: Vec<String>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe unstable?

@kt3k kt3k changed the title feat: add features field feat: add unstable field Oct 5, 2023
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit b98942d into denoland:main Oct 5, 2023
3 checks passed
@kt3k kt3k deleted the add-features-field branch October 5, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants