Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an ExtensionSet to handle logic around multiple extensions #52

Open
mmastrac opened this issue Jul 19, 2023 · 1 comment
Open

Comments

@mmastrac
Copy link
Contributor

There is a fair amount of logic in JsRuntime that deals with collating the data from multiple Extensions. We should move all of this logic to an ExtensionSet that can be initialized from a slice of extensions.

In addition, the ExtensionSet should be extendable to add more extensions to it at a later time. This will allow us to build a base ExtensionSet for the snapshot, then extend it when loading further extensions (for example, for the worker and CLI).

Finally, investigate if we can or should persist the ExtensionSet as part of the snapshot for the purpose of verifying that the correct extensions were passed in as part of snapshot init, or potentially to avoid having to re-create the set of Extensions for the base snapshot.

@nayeemrmn

This comment was marked as outdated.

bartlomieju added a commit that referenced this issue Jan 29, 2024
This commit add "deno_core::runtime::setup" module and factors 
out some non-trivial pieces of logic into standalone functions.

A lot of this code has been organically added over the years and it
becomes harder and harder to reason about op registration as well
as `OpState` setup.

In preparation for #489
Towards #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants