You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a fair amount of logic in JsRuntime that deals with collating the data from multiple Extensions. We should move all of this logic to an ExtensionSet that can be initialized from a slice of extensions.
In addition, the ExtensionSet should be extendable to add more extensions to it at a later time. This will allow us to build a base ExtensionSet for the snapshot, then extend it when loading further extensions (for example, for the worker and CLI).
Finally, investigate if we can or should persist the ExtensionSet as part of the snapshot for the purpose of verifying that the correct extensions were passed in as part of snapshot init, or potentially to avoid having to re-create the set of Extensions for the base snapshot.
The text was updated successfully, but these errors were encountered:
This commit add "deno_core::runtime::setup" module and factors
out some non-trivial pieces of logic into standalone functions.
A lot of this code has been organically added over the years and it
becomes harder and harder to reason about op registration as well
as `OpState` setup.
In preparation for #489
Towards #52
There is a fair amount of logic in
JsRuntime
that deals with collating the data from multipleExtensions
. We should move all of this logic to anExtensionSet
that can be initialized from a slice of extensions.In addition, the
ExtensionSet
should be extendable to add more extensions to it at a later time. This will allow us to build a baseExtensionSet
for the snapshot, then extend it when loading further extensions (for example, for the worker and CLI).Finally, investigate if we can or should persist the
ExtensionSet
as part of the snapshot for the purpose of verifying that the correct extensions were passed in as part of snapshot init, or potentially to avoid having to re-create the set ofExtension
s for the base snapshot.The text was updated successfully, but these errors were encountered: