Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8_static_strings module should use v8::OneByteConst and v8::String::new_from_onebyte_const #527

Closed
bartlomieju opened this issue Jan 31, 2024 · 0 comments · Fixed by #531
Closed

v8_static_strings module should use v8::OneByteConst and v8::String::new_from_onebyte_const #527

bartlomieju opened this issue Jan 31, 2024 · 0 comments · Fixed by #531
Assignees
@bartlomieju

Comments

@bartlomieju
Copy link
Member

These appear to be even cheaper than v8::String::new_external_onebyte_static
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlomieju bartlomieju

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use v8::OneByteConst bartlomieju/deno_core
1 participant
@bartlomieju