Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: run js event loop tick before polling dynamic imports #112

Merged
merged 4 commits into from
Aug 1, 2023
Merged

fix: run js event loop tick before polling dynamic imports #112

merged 4 commits into from
Aug 1, 2023

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Aug 1, 2023 •
edited

This fixes regressions reported in denoland/deno#19903.

We mistakenly were not waking up the event loop again if ops made progress
and there are pending dynamic imports waiting for TLA to resolve.

@bartlomieju bartlomieju mentioned this pull request Aug 1, 2023
Open
mmastrac
mmastrac approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit f86e901 into denoland:main Aug 1, 2023
4 checks passed
@bartlomieju bartlomieju deleted the run_js_event_loop_tick branch August 1, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @mmastrac