Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ops): Support for *const c_void and *mut c_void externals #146

Merged
merged 6 commits into from
Aug 11, 2023
Merged

feat(ops): Support for *const c_void and *mut c_void externals #146

merged 6 commits into from
Aug 11, 2023

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Aug 11, 2023 •
edited

Supports fast and async.

test baseline                               ... bench:         494 ns/iter (+/- 19)
test bench_op_external                      ... bench:       2,043 ns/iter (+/- 44)
test bench_op_external_nofast               ... bench:       8,780 ns/iter (+/- 148)
test bench_op_option_u32                    ... bench:       6,178 ns/iter (+/- 82)
test bench_op_string                        ... bench:       8,178 ns/iter (+/- 125)

@mmastrac mmastrac mentioned this pull request Aug 11, 2023
Closed
18 tasks
bartlomieju
bartlomieju approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmastrac mmastrac enabled auto-merge (squash) August 11, 2023 21:34
@mmastrac mmastrac merged commit 64f32b4 into denoland:main Aug 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmastrac @bartlomieju