Use const fn for op declaration
#685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch op declaration from a `impl #name` to a `const fn #name`. Based on Matt's suggestion in denoland#682 [Playground link](https://play.rust-lang.org/?version=stable&mode=release&edition=2021&gist=2d7152d548b4a466779c401551b21b05) This patch wraps `const` around the existing `impl` codegen to unblock work on op2++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #685 +/- ##
=======================================
Coverage 81.26% 81.26%
=======================================
Files 95 95
Lines 24294 24295 +1
=======================================
+ Hits 19743 19744 +1
Misses 4551 4551 ☔ View full report in Codecov by Sentry. |
mmastrac
reviewed
Apr 6, 2024
ops/op2/mod.rs
Outdated
| #[inline(always)] | ||
| #(#attrs)* | ||
| #op_fn | ||
| #[deprecated(note = "Use the const op::DECL instead")] |
There was a problem hiding this comment.
I'd be OK to remove this as part of this work
mmastrac
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch op declaration from a
impl #nameto aconst fn #name.This form for declaration can be used inside
implblocks.Based on Matt's suggestion in #682
Playground link
This patch wraps
constaround the existingimplcodegen to unblock work on op2++