fix: panic, unwrap to unwrap_or

core/00_primordials.js

@@ -487,6 +487,19 @@
     },
   );
 
+  primordials.ArrayPrototypePush = (thisArray, ...variableArgs) => {
+    const args = [...variableArgs];
+    for (let i = 0; i < args.length; i++) {
+      ObjectDefineProperty(thisArray, thisArray.length, {
+        value: args[i],
+        enumerable: true,
+        writable: true,
+        configurable: true,
+      });
+    }
+    return thisArray.length;
+  };
+
   primordials.ArrayPrototypeToString = (thisArray) =>
     ArrayPrototypeJoin(thisArray);
 

core/error.rs

@@ -444,9 +444,7 @@ impl JsError {
 
       // Convert them into Vec<JsStackFrame>
       let mut frames: Vec<JsStackFrame> = match frames_v8 {
-        Some(frames_v8) => {
-          serde_v8::from_v8(scope, frames_v8.into()).unwrap_or(Vec::new())
-        }
+        Some(frames_v8) => serde_v8::from_v8(scope, frames_v8.into()).unwrap(),
         None => vec![],
       };
       let mut source_line = None;

testing/integration/error_variable_is_not_defined/error_variable_is_not_defined.ts → testing/integration/error_internal_method_set/error_internal_method_set.ts

@@ -3,11 +3,8 @@
 // This test refers to the issue.
 // https://github.com/denoland/deno_core/issues/744
 
-// Using `Object.prototype.__defineSetter__()`,
-// When converting from `serde_v8::from_v8` to `Vec<JsStackFrame>`,
-// Panic is caused by `unwrap_failed`.
 Object.prototype.__defineSetter__(0, function () {});
 
-// Test that JavaScript syntax error statements are output with no panic
+// Need to dare to make errors.
 // For example, `ReferenceError: variable is not defined`.
 variable;

testing/lib.rs

@@ -59,9 +59,9 @@ integration_test!(
   error_rejection_catch,
   error_rejection_order,
   error_ext_stack,
+  error_internal_method_set,
   error_with_stack,
   error_without_stack,
-  error_variable_is_not_defined,
   main_module_handler,
   module_types,
   pending_unref_op_tla,