Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for global template and global object #9

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Support for global template and global object #9

merged 1 commit into from
Jul 6, 2023

Conversation

bartlomieju
Copy link
Member

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mmastrac
mmastrac approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think we'll want to switch from Box<Fn<...>> to fn(...) to avoid a box at startup.

@bartlomieju bartlomieju merged commit 5669776 into denoland:main Jul 6, 2023
4 checks passed
@bartlomieju bartlomieju deleted the node_globals_support branch July 6, 2023 23:24
@bartlomieju
Copy link
Member Author

Let's improve boxing situation after we get everything working in deno itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bartlomieju @CLAassistant @mmastrac @lucacasonato