fix: correct interface properties and methods #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
approved these changes
Nov 28, 2021
Comment on lines
+19
to
+21
| pub(crate) fn is_false(b: &bool) -> bool { | ||
| !b | ||
| } |
There was a problem hiding this comment.
Is there a better way?
Just trying to strip out "useless" fields from the JSON serialization, as with large doc structures, it becomes a "problem". lib.dom.d.ts for example is 9.9mb serialized. 😱
There was a problem hiding this comment.
I feel like we should use this and stuff like skip_serializing_if = "Option::is_none" liberally one day.
There was a problem hiding this comment.
Is there a better way?
No, I think this is right. Still pretty funny though 😅
kitsonk
changed the title
dsherret
reviewed
Nov 29, 2021
| @@ -9,6 +9,7 @@ use crate::js_doc::JsDoc; | |||
| use crate::node::DeclarationKind; | |||
| use crate::params::ts_fn_param_to_param_def; | |||
| use crate::swc_util::get_location; | |||
| use crate::swc_util::is_false; | |||
There was a problem hiding this comment.
No big deal, but this isn't really related to swc.
There was a problem hiding this comment.
There was no other good place to put it and I wasn't going to just create another module for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of tweaks of the interface properties and methods in the documents to properly represent them.