Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle JSDoc for ts type literals #561

Merged
merged 3 commits into from Apr 25, 2024
Merged

feat: handle JSDoc for ts type literals #561

merged 3 commits into from Apr 25, 2024

Conversation

crowlKats
Copy link
Member

Closes #302

dsherret
dsherret reviewed Apr 25, 2024
View reviewed changes
src/ts_type.rs Outdated Show resolved Hide resolved
dsherret
dsherret approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs some pre-allocates or .iter() w/ .map() and .collect() in a few places

src/ts_type.rs Outdated Show resolved Hide resolved
src/ts_type.rs Outdated Show resolved Hide resolved
@crowlKats crowlKats merged commit 6ea914f into main Apr 25, 2024
5 checks passed
@crowlKats crowlKats deleted the tstypeliteral-jsdoc branch April 25, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type Literal Properties and Methods should support JSDoc
2 participants
@crowlKats @dsherret