feat: separate constructors from methods for type literals and interfaces #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
changed the title
|
Can you update the PR description with the reason for the change? It breaks the json output I think? |
dsherret
reviewed
Apr 29, 2024
you are right. i'll add a default serialize for supporting existing jsons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having constructors be methods called
newmakes it difficult for the html generator to render in a proper manner. example of problem when being a method:one option would be to instead separate methods that called
newin the html, but doesnt seem desirable, especially as that wouldnt separate between actual method callednewand constructors.