Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.12.1 #146

Merged
merged 1 commit into from Jul 26, 2021
Merged

1.12.1 #146

merged 1 commit into from Jul 26, 2021

Conversation

satyarohith
Copy link
Member

No description provided.

Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It is worrying that we have to update this every time we do a release. Is there not a way to have the images install the latest release by default?

@bartlomieju bartlomieju mentioned this pull request Jul 26, 2021
@hayd
Copy link
Contributor

hayd commented Jul 26, 2021

You have to do an active push to dockerhub on each release.

In a plain old dockerfile you don't need to specify the version.

I suppose what you could simply do a push immediately after release with the knowledge the deno it will use the latest. But having a dockerfile (the dockerfile used to generate an image is public/visible) be dependent on the side-effects of the latest deno released feels pretty shady/against convention.

There is a script to do this update/autoroll. But I don't think it's been wired up:
https://github.com/denoland/deno_docker/blob/main/_update_deno.ts

Edit: Hope this makes some sense, incredibly tired when writing this :) don't think have articulated well!

@satyarohith satyarohith merged commit 9be630c into denoland:main Jul 26, 2021
@satyarohith satyarohith deleted the 1.12.1 branch July 26, 2021 19:25
@satyarohith
Copy link
Member Author

satyarohith commented Jul 26, 2021

@hayd, thanks for pointing to the autoroll script; I opened an issue to re-enable it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants