Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle dts files in fast check #388

Merged
merged 3 commits into from
Feb 16, 2024
Merged

fix: handle dts files in fast check #388

merged 3 commits into from
Feb 16, 2024

Conversation

dsherret
Copy link
Member

Closes #373

dsherret
dsherret commented Feb 16, 2024
View reviewed changes
src/fast_check/swc_helpers.rs
use deno_ast::swc::ast::TsTypeRef;
use std::rc::Rc;

use deno_ast::swc::ast::*;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a bit of cleanup in this PR at the same time. Generally we don't use *, but I think it's ok in this module.

@dsherret dsherret merged commit a76eee9 into denoland:main Feb 16, 2024
4 checks passed
@dsherret dsherret deleted the fix_dts_fast_check branch February 16, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zap tries to zap d.ts files
2 participants
@dsherret @marvinhagemeister