Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fast_check): properly handle rest parameters in overloads #432

Merged
merged 3 commits into from Apr 11, 2024
Merged

fix(fast_check): properly handle rest parameters in overloads #432

merged 3 commits into from Apr 11, 2024

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Apr 11, 2024 •
edited

@atjn
Copy link

atjn commented Apr 11, 2024

Wow that was a fast turnaround. Thank you very much!

dsherret
dsherret approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 523d1e2 into denoland:main Apr 11, 2024
4 checks passed
@dsherret dsherret mentioned this pull request Apr 11, 2024
Merged
dsherret added a commit to denoland/deno that referenced this pull request Apr 11, 2024
@dsherret
fix: upgrade deno_ast related crates (#23187)
ade0cd5 
Had to revert back swc due to
swc-project/swc#8840

Fixes:

- denoland/deno_lint#1262
- denoland/deno_doc#538
- denoland/deno_doc#537
- denoland/deno_graph#430
- denoland/deno_graph#425
- denoland/deno_graph#432
bartlomieju pushed a commit to denoland/deno that referenced this pull request Apr 12, 2024
@dsherret @bartlomieju
fix: upgrade deno_ast related crates (#23187)
a5dab06 
Had to revert back swc due to
swc-project/swc#8840

Fixes:

- denoland/deno_lint#1262
- denoland/deno_doc#538
- denoland/deno_doc#537
- denoland/deno_graph#430
- denoland/deno_graph#425
- denoland/deno_graph#432
@lucacasonato lucacasonato mentioned this pull request Apr 12, 2024
Merged
@dsherret dsherret mentioned this pull request Apr 12, 2024
Closed
littledivy pushed a commit to littledivy/deno that referenced this pull request Apr 19, 2024
@dsherret @littledivy
fix: upgrade deno_ast related crates (denoland#23187)
57ff383 
Had to revert back swc due to
swc-project/swc#8840

Fixes:

- denoland/deno_lint#1262
- denoland/deno_doc#538
- denoland/deno_doc#537
- denoland/deno_graph#430
- denoland/deno_graph#425
- denoland/deno_graph#432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typechecking breaks on class method with generic args
4 participants
@lucacasonato @atjn @marvinhagemeister @dsherret