Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsr): https import of jsr dep that has a dependency #466

Merged
merged 3 commits into from May 7, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 3, 2024

Currently just have the failing tests here.

For denoland/deno#23644

@dsherret dsherret marked this pull request as ready for review May 7, 2024 19:05
@dsherret dsherret requested a review from bartlomieju May 7, 2024 19:05
.graph
.packages
.ensure_package(pkg.nv, pkg.manifest_checksum);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the bug. Basically it needs to record that we imported this package.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit a8ed1bc into denoland:main May 7, 2024
4 checks passed
@dsherret dsherret deleted the fix_https_import_jsr_dep branch May 7, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants