Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support analysis of JSDoc imports #92

Merged
merged 4 commits into from Dec 21, 2021
Merged

feat: support analysis of JSDoc imports #92

merged 4 commits into from Dec 21, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Dec 21, 2021

Closes #91

bartlomieju
bartlomieju reviewed Dec 21, 2021
View reviewed changes
src/ast.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sans missing assertion

dsherret
dsherret approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the one test Bartek pointed out.

@kitsonk kitsonk merged commit 9fa1cc9 into denoland:main Dec 21, 2021
@kitsonk kitsonk deleted the kitsonk/issue91 branch December 21, 2021 21:06
@jespertheend jespertheend mentioned this pull request Jan 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

graph does not analyze JSDoc imports
3 participants
@kitsonk @dsherret @bartlomieju