Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-named PowerShell installer broken #33

Closed
MarkTiedemann opened this issue Jan 23, 2019 · 0 comments
Closed

Non-named PowerShell installer broken #33

MarkTiedemann opened this issue Jan 23, 2019 · 0 comments

Comments

@MarkTiedemann
Copy link
Contributor

iex (iwr https://deno.land/x/install/install.ps1)

iex doesn't work with param. See https://ci.appveyor.com/project/MarkTiedemann/win-ci-playground/builds/21844216.

So apparently this installation method hasn't worked since #22.

This is easy to fix, luckily:

if ($args.Count -gt 0) {
  $Version = $args.Get(0)
}

I already tested it, and it works: https://ci.appveyor.com/project/MarkTiedemann/win-ci-playground/builds/21844766.

Will make a PR for it tomorrow and also add proper end-to-end tests for that.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant