Support 7z besides unzip
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fan of this pr, since 7z is the only option for installing it on Synology DSM. See Issue #260 |
SyedAshfan
approved these changes
May 22, 2023
|
Could this be merged? Apparently it's already reviewed, so it would be nice if it'd land shortly! :) |
|
@bartlomieju Could you review this patch? |
mmastrac
reviewed
Feb 7, 2024
mmastrac
reviewed
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now install.sh works if either
unzipor7zis available. There are people who prefer7zoverunzipeven for extracting ZIP files so that they are not willing to installunzipbesides7z. This change could make such people happy. Furthermore, there are some minimal Linux distributions that ship with only7z(e.g., Synology DSM).